Re: [PATCH v2] iommu: Add event tracing feature to iommu

[Joerg Roedel]

Hi Shuah,

thanks for doing this. I have a few suggestions for improvements.

On Tue, Jul 30, 2013 at 08:57:09AM -0600, Shuah Khan wrote:
> iommu:add_device_to_group
> iommu:remove_device_from_group
> iommu:attach_device_to_domain
> iommu:detach_device_from_domain
> iommu:unmap
> iommu:map

Please send these events as seperate patches.

> iommu:amd_event

This needs some more thought. For now I would prefer an event in the
generic report_iommu_fault() routine to report page-faults from all IOMMUs
that support this.

Thanks,

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/