Re: [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO isdetected

From: Greg KH
Date: Wed Aug 14 2013 - 15:17:45 EST


On Tue, Aug 13, 2013 at 09:32:13AM -0500, Mark Rusk wrote:
> Using an uninitialized variable 'devnum' after 'goto out;' was causing
> panic. Just go ahead and return, we need to ignore AUX iLO devs.
>
> Oops: 0002 [#1] SMP
> .
> .
> .
> RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
> ---
> drivers/misc/hpilo.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

I think you forgot to run this patch through the checkpatch.pl tool
before you sent it out, right (hint, no signed-off-by line...)

Please fix it up and resend, so that it can be applied...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/