Re: [PATCH] workqueue: Fix manage_workers() RETURNS description

[Tejun Heo]

On Fri, Aug 16, 2013 at 01:33:35PM +0800, Libin wrote:
> @@ -2033,8 +2033,8 @@ static bool maybe_destroy_workers(struct worker_pool *pool)
>   * multiple times.  Does GFP_KERNEL allocations.
>   *
>   * RETURNS:
> - * spin_lock_irq(pool->lock) which may be released and regrabbed
> - * multiple times.  Does GFP_KERNEL allocations.
> + * %false if the poll don't need management and the caller can safely 
                    ^
		    typo

> + * start processing works, %true otherwise.

So, %true indicates that the function released pool->lock and
reacquired it to perform some management function and that the
conditions that the caller verified while holding the lock before
calling the function might no longer be true.

Can you please update the patch accordingly?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/