Re: [PATCH v2] dmaengine: make dmatest less noisy

[Joe Perches]

On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
> Commit 95019c8c5 "dmatest: gather test results in the linked list"
> started to warning whenever we add results to a test thread.
> A warning for something completely normal? This is just cluttering
> my terminal. Move to debug prints.
[]
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
[]
> @@ -36,7 +36,7 @@ static char test_device[20];
>  module_param_string(device, test_device, sizeof(test_device), S_IRUGO);
>  MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
>  
> -static unsigned int threads_per_chan = 1;
> +static unsigned int threads_per_chan = 8;
>  module_param(threads_per_chan, uint, S_IRUGO);
>  MODULE_PARM_DESC(threads_per_chan,
>  		"Number of threads to start per channel (default: 1)");

This is unrelated and makes the MODULE_PARAM_DESC below
it have the incorrect default.

> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
>  	list_add_tail(&tr->node, &r->results);
>  	mutex_unlock(&info->results_lock);
>  
> -	pr_warn("%s\n", thread_result_get(r->name, tr));
> +	pr_debug("%s\n", thread_result_get(r->name, tr));
>  	return 0;
>  }
>  

This bit is sensible though.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/