Re: [PATCH] pinctrl: Pass all configs to driver on pin_config_set()

From: Stephen Warren
Date: Mon Aug 19 2013 - 15:20:21 EST


On 08/15/2013 04:42 PM, Sherman Yin wrote:
> When setting pin configuration in the pinctrl framework, pin_config_set() or
> pin_config_group_set() is called in a loop to set one configuration at a time
> for the specified pin or group.
>
> This patch 1) removes the loop and 2) changes the API to pass the whole pin
> config array to the driver. It is now up to the driver to loop through the
> configs. This allows the driver to potentially combine configs and reduce the
> number of writes to pin config registers.
>
> Signed-off-by: Sherman Yin <syin@xxxxxxxxxxxx>
> Reviewed-by: Christian Daudt <csd@xxxxxxxxxxxx>
> Reviewed-by: Matt Porter <matt.porter@xxxxxxxxxx>

> Change-Id: I99cbfa2ae7b774456eb71edb276711b1ddcd42c8

That tag shouldn't be included in upstream patches.

> drivers/pinctrl/pinconf.c | 42 ++++----
> drivers/pinctrl/pinctrl-tegra.c | 69 ++++++------
> include/linux/pinctrl/pinconf.h | 6 +-

Those files, Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>

On Tegra (Tegra114 Dalmore board, on top of next-20130816),
Tested-by: Stephen Warren <nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/