Re: [PATCH 4/4] mfd: as3722: introduce regmap support

[Lee Jones]

On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> 
> Signed-off-by: Florian Lobmaier <florian.lobmaier@xxxxxxx>
> ---
>  drivers/mfd/as3722-regmap.c |  417 +++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 417 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mfd/as3722-regmap.c

I'll leave the review of this file to Mark, but it should be added
either when you start calling the functions, or at least before they
are used, or else the preceding commits won't build. This would cause
someone a major headache if their bisect landed in the middle of your
patches.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/