Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB driversfor DWC3 core

From: Felipe Balbi
Date: Tue Aug 20 2013 - 09:37:57 EST


Hi,

On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote:
> > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote:
> > > From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx>
> > >
> > > These drivers handles control and configuration of the HS
> > > and SS USB PHY transceivers. They are part of the driver
> > > which manage Synopsys DesignWare USB3 controller stack
> > > inside Qualcomm SoC's.
> > >
> > > Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>
> > > ---
> > > drivers/usb/phy/Kconfig | 11 ++
> > > drivers/usb/phy/Makefile | 2 +
> > > drivers/usb/phy/phy-msm-dwc3-hs.c | 327 ++++++++++++++++++++++++++++++++
> > > drivers/usb/phy/phy-msm-dwc3-ss.c | 374 +++++++++++++++++++++++++++++++++++++
> >
> > please rename these PHY drivers, they have nothing to do with DWC3. PHYs
> > don't care about the USB controller.
>
> I think they are SNPS DesignWare PHY's, additionally
> wrapped with Qualcomm logic. I could substitute "dwc3"
> with just "dw", which will be more correct.

alright, thank you. Let's add Paul to the loop since he might have very
good insight in the synopsys PHYs.

mental note: if any other platform shows up with Synopsys PHY, ask them
to use this driver instead :-)

--
balbi

Attachment: signature.asc
Description: Digital signature