Re: [ 00/34] 3.4.59-stable review

[Hugh Dickins]

On Tue, 20 Aug 2013, Greg Kroah-Hartman wrote:
> On Tue, Aug 20, 2013 at 08:53:24AM -0700, Hugh Dickins wrote:
> > On Tue, 20 Aug 2013, Greg Kroah-Hartman wrote:
> > > On Tue, Aug 20, 2013 at 07:36:00AM +0000, Berg, Johannes wrote:
> > > > > > [ 26/34] genetlink: fix family dump race
> > > > > 
> > > > > Johannes, another strike against this patch :(
> > > > > 
> > > > > Any chance on fixing it upstream and me sucking that fix in?
> > > > 
> > > > Yeah, I'm trying to get that, but it's not clear to me how to fix it.
> > > > Where did you apply it? It was going to need some fixes but when the
> > > > first objection was raised I figured you were going to drop it for now
> > > > completely? Sorry for the mess :-(
> > > 
> > > You're right, I'll drop this for 3.4, it doesn't make sense there.
> > 
> > And you'll drop it from 3.0 and 3.10 also, I hope?
> 
> It wasn't in 3.0, was it?  Oh crap, it was...
> 
> 3.10, I'd rather have the "real" fix that ends up resolving the issue in
> Linus's tree also, instead of just dropping it.

We would all prefer that, but as yet the real fix is unknown,
and lockdep shows problems with the real fix (please search your
mailbox for "3.11-rc6 genetlink locking fix offends lockdep").

> 
> Especially as I just did the releases...

Oh.  Classic case of a patch rushed too quickly into late rc,
then too quickly from there to stable.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/