Re: [PATCH 5/9] target: Skip ->queue_data_in() callbacks forCOMPARE_AND_WRITE

From: Christoph Hellwig
Date: Wed Aug 21 2013 - 02:32:28 EST


> @@ -1832,7 +1832,8 @@ static void transport_complete_qf(struct se_cmd *cmd)
> ret = cmd->se_tfo->queue_data_in(cmd);
> break;
> case DMA_TO_DEVICE:
> - if (cmd->t_bidi_data_sg) {
> + if (cmd->t_bidi_data_sg &&
> + cmd->t_task_cdb[0] != COMPARE_AND_WRITE) {

This is not the place to hardcode specific cdb opcodes. Should be
a flag with a defined meaning on the command.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/