Re: [PATCH 9/9] tcm_qla2xxx: Add special case for COMPARE_AND_WRITEdata_direction

[Christoph Hellwig]

On Wed, Aug 21, 2013 at 12:31:07AM -0700, Nicholas A. Bellinger wrote:
> Is it really worth having two se_cmd_flags for COMPARE_AND_WRITE..?

Not leaking the abstraction into the driver is always worth the effort.

But looking at the other patches I haven't reviewed yet I think the
issue is more severe anyway, see my next reply.

> > Also it might make sense to lift this helper to get a dma direction from
> > a command into common code.
> > 
> 
> Mmm, perhaps.  I don't recall of the top of my head why tcm_qla2xxx
> actually needed to reverse it's dma direction (I'm sure that Roland
> knows, CC'ed), but IIRC it was a tcm_qla2xxx specific thing..?

It's the same issue for any hardware driver that directly maps a
se_cmd - the direction the target expects is reversed to what the
driver expects, in addition any BIDI or other special meanings will
need handling.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/