Re: [PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore devicetree

[Stephen Warren]

On 08/21/2013 06:34 AM, Laxman Dewangan wrote:
> Add Palmas pincontrol to Dalmore device tree and make following
> configuration as default:
> - Disable DVFS1 and DVFS2.
> - Set GPIO6 to gpio mode.

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts

> +			palmas_pinctrl {
> +				compatible = "ti,tps65913-pinctrl";

A node name of "pinmux" would be more appropriate here, since the node
name should represent device type rather than device identity.

Aside from that, the series looks fine, but at this point will have to
wait for 3.13 I think, unless this series has a side-effect of fixing
some bug/regression. Can you please repost once 3.12-rc1 is out?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/