Re: [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX

[Laxman Dewangan]

On Thursday 22 August 2013 12:00 PM, Axel Lin wrote:
> Fix below build error if !PINMUX.
>
>    CC      drivers/pinctrl/pinctrl-palmas.o
> drivers/pinctrl/pinctrl-palmas.c:741:21: error: variable 'palmas_pinmux_ops' has initializer but incomplete type
> drivers/pinctrl/pinctrl-palmas.c:742:2: error: unknown field 'get_functions_count' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: error: unknown field 'get_function_name' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: error: unknown field 'get_function_groups' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: error: unknown field 'enable' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> make[2]: *** [drivers/pinctrl/pinctrl-palmas.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
>   drivers/pinctrl/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 8542cd4..ae8b747 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -264,6 +264,7 @@ config PINCTRL_EXYNOS5440
>   config PINCTRL_PALMAS
>   	bool "Pinctrl driver for the PALMA Series MFD devices"
>   	depends on OF && MFD_PALMAS
> +	select PINMUX
>   	select GENERIC_PINCONF
>   	help
>   	  Palmas device supports the configuration of pins for different

Yes, this is needed. In mainline, it is not creating issue for Tegra as 
it is already selecting PINMUX for Tegra.
I found this issue on yesterday only in our downstream when porting it 
for  new boards with new config.
You won the race of sending patch ;-).

Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/