Re: Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflictswith existing use

[Jan Beulich]

>>> On 22.08.13 at 09:03, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> Ok, how about this?
> 
> static inline pte_t pte_swp_mksoft_dirty(pte_t pte)
> {
> 	BUG_ON(pte_present(pte));
> 	return pte_set_flags(pte, _PAGE_SWP_SOFT_DIRTY);
> }

Sure, fine with me. Perhaps VM_BUG_ON() or some other similar
construct limiting the scope when any extra code gets generated
would do too.

But as said, even better would perhaps be to have it act on a
swp_entry_t.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/