Re: [RFC PATCH] phylib: mdio: handle register/unregister/registersequence

[boris brezillon]

Hello Florian,

Thanks for your answer.

On 22/08/2013 14:43, Florian Fainelli wrote:
> Hello Boris,
>
> 2013/8/22 Boris BREZILLON <b.brezillon@xxxxxxxxxxx>:
> > Hello,
> >
> > This patch is a proposal to support the register/unregister/register
> > sequence on a given mdio bus.
> >
> > I use the register/unregister/register sequence to add a fallback when the
> > of_mdiobus_register (this function calls mdiobus_register with phy_mask
> > set to ~0) does not register any phy device (because the device tree does
> > not define any phy).
> > In this case I call mdiobus_unregister and then call mdiobus_register with
> > a phy_mask set to 0 to trigger a full mdio bus scan.
> >
> > I'm not sure this is the right way to do it (this is why I added RFC in the
> > subject).
> >
> > Could someone help me figuring out what I should use to implement my fallback ?
> >
> > 1) use the register/unregister/register sequence
> > 2) reimplement the "for (i = 0; i < PHY_MAX_ADDR; i++)" mdiobus_scan loop
> I think solution 2 is nicer, in that case, would it be enough in your
> case to export a function called mdiobus_scan()? You could call at a
> time you know PHY devices have a chance of having been probed?
mdiobus_scan is already exported:
struct phy_device *mdiobus_scan(struct mii_bus *bus, int addr);

This function scans the presence of a phy device at a given address.

What I need is a loop which scan all the possible address on the given
mdio bus:

struct phy_device *mdiobus_full_scan(struct mii_bus *bus)
{
    int i;
    for (i = 0; i < PHY_MAX_ADDR; i++) {
        if ((bus->phy_mask & (1 << i)) == 0) {
            struct phy_device *phydev;

            phydev = mdiobus_scan(bus, i);
            if (IS_ERR(phydev)) {
                err = PTR_ERR(phydev);
                goto error;
            }
        }
    }
    return 0;

error:
    while (--i >= 0) {
        if (bus->phy_map[i])
            device_unregister(&bus->phy_map[i]->dev);
    }
}
EXPORT_SYMBOL(mdiobus_full_scan);

Since I am the only one who need this kind of functionnality right now, 
I'm not sure
this is a good idea to export a new function.

This behaviour may be implemented in the of_mdiobus_register function:
when no dt phy node are found in the mdio bus dt node, we could launch a 
full
scan.

What do you think ?

Best Regards,

Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/