Re: [PATCH 3/3] raid6/test: replace echo -e with printf

From: H. Peter Anvin
Date: Thu Aug 22 2013 - 11:09:37 EST


Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
>-e is a non-standard echo option, echo output is
>implementation-dependent when it is used. Replace echo -e with printf
>as
>suggested by POSIX echo manual.
>
>Cc: NeilBrown <neilb@xxxxxxx>
>Cc: Jim Kukunas <james.t.kukunas@xxxxxxxxxxxxxxx>
>Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
>Cc: Yuanhan Liu <yuanhan.liu@xxxxxxxxxxxxxxx>
>Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
>---
> lib/raid6/test/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
>index 087332d..73b0151 100644
>--- a/lib/raid6/test/Makefile
>+++ b/lib/raid6/test/Makefile
>@@ -28,7 +28,7 @@ ifeq ($(IS_X86),yes)
> gcc -c -x assembler - >&/dev/null && \
> rm ./-.o && echo -DCONFIG_AS_AVX2=1)
> else
>- HAS_ALTIVEC := $(shell echo -e '\#include <altivec.h>\nvector
>int a;' |\
>+ HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector
>int a;\n' |\
> gcc -c -x c - >&/dev/null && \
> rm ./-.o && echo yes)
> ifeq ($(HAS_ALTIVEC),yes)

--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/