Re: [PATCH v2 2/2] ARM: at91/dt: define phy available on sama5d3mother board

[boris brezillon]

Hello Sergei,

On 26/08/2013 15:21, Sergei Shtylyov wrote:
> Hello.
>
> On 26-08-2013 16:35, Boris BREZILLON wrote:
>
> > This patch describe the phy used on atmel sama5d3 mother board:
> >   - phy address
> >   - phy interrupt pin
>
> > Signed-off-by: Boris BREZILLON <b.brezillon@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/sama5d3xmb.dtsi |    8 ++++++++
> >   1 file changed, 8 insertions(+)
>
> > diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi 
> > b/arch/arm/boot/dts/sama5d3xmb.dtsi
> > index 8a9e05d..e9521d5 100644
> > --- a/arch/arm/boot/dts/sama5d3xmb.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi
> > @@ -81,6 +81,14 @@
> >
> >               macb1: ethernet@f802c000 {
> >                   phy-mode = "rmii";
> > +
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> > +                phy0: ethernet-phy@0 {
>
>    Address part of the node name doesn't match the "reg" property.

Indeed, I based my definition on arch/arc/boot/dts/angel4.dts where phy 
is registered like this :

            phy0: ethernet-phy@0 {
                reg = <1>;
            };

I think it's buggy there too, because I checked other dts files and they 
all put the same address
after @ and in reg register.

I'll fix this fot the next version.

Thanks

Best Regards,
Boris



> > +                    interrupt-parent = <&pioE>;
> > +                    interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
> > +                    reg = <1>;
> > +                };
>
> WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/