Re: [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume

From: Guenter Roeck
Date: Mon Aug 26 2013 - 12:06:36 EST


On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
> > Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
> > ohci-pci.c) added missing ohci_suspend and ohci_resume callback
> > pointers, but forgot that these callbacks are declared and defined
> > only when CONFIG_PM is enabled.
> >
> > This patch adds a preprocessor conditional to avoid build errors when
> > PM is disabled.
> >
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> >
> > ---
>
> Guenter and Meelis, does the patch below fix the problem for you?
>
Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Previously failing builds:
mips:ath79_defconfig
powerpc:ppc64e_defconfig
powerpc:cell_defconfig
powerpc:maple_defconfig
parisc:defconfig
tile:defconfig
sparc32:defconfig
sparc64:defconfig

as well as the powerpc qemu test (with the config file used
by the yocto project)

All builds pass with the patch applied, as does the qemu test.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/