Re: Re: [RFC PATCH 08/11] trace-cmd: Apply the trace-msg protocolfor communication between a server and clients

[Yoshihiro YUNOMAE]

(2013/08/27 0:11), Steven Rostedt wrote:
> On Mon, 26 Aug 2013 10:50:33 +0900
> Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@xxxxxxxxxxx> wrote:
>
> > <Network>
> > 0. old server and old client
> > Old servers send "tracecmd" as the first message.
> > Old clients compare the first 8byte of the first message with "tracecmd".
> >
> > 1. new server
> > - Send "tracecmd-v2" as the first message.
> > - Check the reply message whether the message is "tracecmd-v2" or cpus
> >     value.
> >     If "tracecmd-v2", the server uses new protocol and wait for the
> >     message MSG_TINIT.
> >     If cpus value, the server uses old protocol.
>
> That will kill an old client. Yes it only checks the first 8 bytes, but
> then it gets back a comma separated list of CPUs. As it uses TCP for
> this transaction, the unread "-v2" will end up being read as CPUs by
> the client.

Ah, that's true. This method is inappropriate.

> > 2. new client
> > - Receive the first message.
> > - Check the message whether the message is "tracecmd-v2" or not.
> >     If "tracecmd-v2", the client sends "tracecmd-v2" to the server. Then,
> >     the client sends the message MSG_TINIT.
> >     If "tracecmd", the client sends cpus value as the old protocol.
>
> It will have to be the client that determines if the protocol is v2 or
> not. Basically, after receiving the "tracecmd" the client can send back
> "V2", and then expect the server to reply with "V2" as well. If the
> server does not, then it disconnects from the server and then restarts
> with the old protocol.

OK, let me check that. Even if the old server will receive "V2", the
server will send port numbers instead of "V2" due to the old protocol.
In that time, the new client will disconnect from the old server and
the restarts with the old protocol. Is it OK?

Thanks!
Yoshihiro YUNOMAE

--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/