Re: [PATCH] kvm tools: powerpc: Fix init order for xics

[Pekka Enberg]

On Tue, Aug 20, 2013 at 6:28 AM, Michael Neuling <mikey@xxxxxxxxxxx> wrote:
> xics_init() assumes kvm->nrcpus is already setup.  kvm->nrcpus is setup
> in kvm_cpu_init()
>
> Unfortunately xics_init() and kvm_cpu_init() both use base_init().  So
> depending on the order randomly determined by the compiler, xics_init()
> may initialised see kvm->nrcpus as 0 and not setup any of the icp VCPU
> pointers.  This manifests itself later in boot when trying to raise an
> IRQ resulting in a null pointer deference/segv.
>
> This moves xics_init() to use dev_base_init() to ensure it happens after
> kvm_cpu_init().
>
> Signed-off-by: Michael Neuling <mikey@xxxxxxxxxxx>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/