Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

[Mateusz Krawczuk]

On 08/27/2013 11:30 AM, Sylwester Nawrocki wrote:
> Hi,
>
> Just a few nits...
>
> On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote:
> > This patch implements pinctrl for s5pv210 and adds required device tree bindings.
> Would be good to wrap this to not exceed 80 columns.
>
> > Signed-off-by: Mateusz Krawczuk <m.krawczuk@xxxxxxxxxxxxxxxxxxx>
> > ---
> [...]
> > diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c
> > index a74b3cb..fc3e1d7 100644
> > --- a/drivers/pinctrl/pinctrl-exynos.c
> > +++ b/drivers/pinctrl/pinctrl-exynos.c
> > @@ -660,6 +660,64 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
> >   			exynos_pinctrl_resume_bank(drvdata, bank);
> >   }
> >   
> > +/* pin banks of s5pv210 pin-controller */
> > +static struct samsung_pin_bank s5pv210_pin_banks0[] = {
> Couldn't it be 'static const' ?
Using static const cause warning: initialization discards ‘const’ 
qualifier from pointer target type
> > +	EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpa0", 0x00),
> > +	EXYNOS_PIN_BANK_EINTG(6, 0x020, "gpa1", 0x04),
> > +	EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpb", 0x08),
> > +	EXYNOS_PIN_BANK_EINTG(5, 0x060, "gpc0", 0x0c),
> > +	EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpc1", 0x10),
> > +	EXYNOS_PIN_BANK_EINTG(4, 0x0A0, "gpd0", 0x14),
> > +	EXYNOS_PIN_BANK_EINTG(4, 0x0C0, "gpd1", 0x18),
> > +	EXYNOS_PIN_BANK_EINTG(5, 0x0E0, "gpe0", 0x1c),
> How about consistently using lower case for the hex numbers ?
Thanks, I will use lower case.
> --
> Thanks,
> Sylwester
Best regards,
Mateusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/