Re: [PATCH 3/4] asm-generic: Add missing include guards

From: James Hogan
Date: Tue Aug 27 2013 - 09:09:01 EST


On 08/08/13 22:07, Rasmus Villemoes wrote:
> Add include guards to include/asm-generic/{ide_iops,unistd,xor}.h.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> include/asm-generic/ide_iops.h | 4 ++++
> include/asm-generic/unistd.h | 5 +++++
> include/asm-generic/xor.h | 4 ++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h
> index cccc86e..0cff2e9 100644
> --- a/include/asm-generic/unistd.h
> +++ b/include/asm-generic/unistd.h
> @@ -1,3 +1,6 @@
> +#ifndef _ASM_GENERIC_UNISTD_H
> +#define _ASM_GENERIC_UNISTD_H
> +
> #include <uapi/asm-generic/unistd.h>
> #include <linux/export.h>
>
> @@ -10,3 +13,5 @@
> #define __ARCH_WANT_STAT64
> #define __ARCH_WANT_SYS_LLSEEK
> #endif
> +
> +#endif /* _ASM_GENERIC_UNISTD_H */

I think the lack of include guards in unistd.h is intentional. See for
example the very end of arch/metag/kernel/sys_metag.c.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/