Re: [PATCH] proc: make proc_fd_permission() thread-friendly

From: Oleg Nesterov
Date: Tue Aug 27 2013 - 11:51:41 EST


On 08/26, Andy Lutomirski wrote:
>
> On Aug 26, 2013 12:35 PM, "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>
> wrote:
> >
> > Yes, it would be semantically different, but it would mean that
> > "/proc/self/fd/" would actually make sense in a way that it currently
> > does *not* - which would seem fairly important, since the primary use
> > for it tends to be /dev/stdin.
> >
> > And the other semantic differences might be much harder to notice.
> > Worth testing?
>
> The "children" subdirectory will be different. But it's already screwed up.

No, it lives in tid_base_stuff, it should be only visible in
/proc/*/task/tid/ dir.

(and perhaps it also makes sense to remove mem/exe-like things from
tid_base_stuff...)

Anyway I agree, this change is risky.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/