Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

[Felipe Balbi]

On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote:
> On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote:
> > If NO_DMA=y:
> > 
> > drivers/built-in.o: In function `dma_set_coherent_mask':
> > include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/chipidea/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> > index d1bd8ef..dbd5232 100644
> > --- a/drivers/usb/chipidea/Kconfig
> > +++ b/drivers/usb/chipidea/Kconfig
> > @@ -1,6 +1,6 @@
> >  config USB_CHIPIDEA
> >  	tristate "ChipIdea Highspeed Dual Role Controller"
> > -	depends on USB || USB_GADGET
> > +	depends on (USB || USB_GADGET) && HAS_DMA
> >  	help
> >  	  Say Y here if your system has a dual role high speed USB
> >  	  controller based on ChipIdea silicon IP. Currently, only the
> 
> I can't understand why the DMA can't be changed to fix this instead
> of changing every driver?

I'm with you. It'd be nicer to just provide empty stubs when !HAS_DMA

-- 
balbi

Attachment: signature.asc
Description: Digital signature