Re: [PATCH] debugfs: provide debugfs_create_x64() when disabled

From: Johannes Berg
Date: Wed Aug 28 2013 - 02:39:17 EST


On Tue, 2013-08-27 at 22:08 -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2013 at 09:58:30AM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > commit 15b0beaa332b3923cc ("Add x64 support to debugfs") added
> > debugfs_create_x64(), but forgot to provide it when debugfs is
> > disabled, causing problems when code tries to use it even then.
> > Provide the appropriate static inline.
>
> That's funny, given that it's been this way for over 3 years without
> anyone noticing :)

Heh. I only noticed because the ath9k driver was broken and selected
mac80211 debugfs without regard for DEBUG_FS configuration, and thus it
failed compile on this. This is a Kconfig bug, so I don't really need
this inline and it will never get used, but I figured debugfs has all
inlines so it should have this one as well.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/