Re: [PATCH] net: mdio-sun4i: Convert to devm_* api

From: Maxime Ripard
Date: Wed Aug 28 2013 - 05:35:19 EST


Hi Jisheng,

On Mon, Aug 26, 2013 at 09:11:57PM +0800, Jisheng Zhang wrote:
> Use devm_ioremap_resource instead of of_iomap() and devm_kzalloc()
> instead of kmalloc() to make cleanup paths simpler. This patch also
> fixes the resource leak caused by missing corresponding iounamp()
> of the of_iomap().
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>

It looks fine for me.
Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature