Re: [PATCH 4/5] ARM: tegra: Add host1x, dc and hdmi to Tegra114 devicetree
From: Mikko Perttunen
Date: Wed Aug 28 2013 - 08:41:42 EST
On 08/28/2013 03:25 PM, Thierry Reding wrote:
* PGP Signed by an unknown key
On Wed, Aug 28, 2013 at 01:40:58PM +0300, Mikko Perttunen wrote:
Add host1x, dc (display controller) and hdmi devices to Tegra114
device tree.
"DC" and "HDMI".
Will fix.
Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
---
arch/arm/boot/dts/tegra114.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 2905145..ce5a95c 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -27,6 +27,49 @@
(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
};
+ host1x {
+ compatible = "nvidia,tegra114-host1x", "nvidia,tegra30-host1x",
I don't think that's correct. The Tegra114 host1x is not backwards
compatible with the Tegra30 host1x.
That said, I have a local patch that is a bit more complete in that it
adds other host1x devices as listed in the TRM as well. But I'll leave
it up to Stephen how he prefers to handle that. It should be fine to
defer adding nodes for additional hardware blocks when the supporting
drivers are merged. We've done it for other devices as well.
Ok. Will need to add tegra114-host1x to the host1x driver compat
strings, then, but I guess that's better than having it wrong in the DT.
+ "simple-bus";
+ reg = <0x50000000 0x00028000>;
+ interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
I think this should be indented with the previous line. Also other SoC
.dtsi files use a single entry, as in:
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH
GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
Will fix.
+ hdmi {
+ compatible = "nvidia,tegra114-hdmi";
+ reg = <0x54280000 0x00040000>;
+ interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&tegra_car TEGRA114_CLK_HDMI>,
+ <&tegra_car TEGRA114_CLK_PLL_D_OUT0>;
Any reason why we can't use pll_d2_out0 here, like we do on Tegra30?
I have this set to PLL_D because I don't have panel support so disp1
will be the HDMI DC. However, it doesn't seem to matter which one is
specified here. I have also tested HDMI with disp2 and that works too.
Thierry
* Unknown Key
* 0x7F3EB3A1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/