Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue withclang.

From: H. Peter Anvin
Date: Thu Aug 29 2013 - 14:12:27 EST


On 08/29/2013 11:00 AM, Jan-Simon Möller wrote:
>>
>> You just changed the sematics of the _ASM_* macros... that doesn't seem
>> like a great idea. It's probably okay for the registers, but still...
>
> Well, we followed your idea for the _ASM_DX macros as you mentioned them
> earlier.
>

We can probably do this, because register names are usually not assumed
to have spaces around them... so it's probably okay. Definitely a lot
less ugly than the rest. That being said, if we're going to fix these
macros, we should also fix another piece of drain bramage:

ALL instances of these have a % prepended. The % should be part of the
macro.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/