Re: On the correctness of dbe3ed1c078c193be34326728d494c5c4bc115e2

From: H. Peter Anvin
Date: Sun Sep 01 2013 - 12:01:27 EST


On 09/01/2013 08:58 AM, Linus Torvalds wrote:
> On Sun, Sep 1, 2013 at 5:20 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>
>> This has the end result that we treat a user space instruction which
>> touches a privileged data structure that then page faults (e.g. a
>> segment load which causes #PF on the GDT) as a user-space fault.
>>
>> This seems very wrong to me, since such a #PF would indicate a serious
>> error in the kernel.
>
> Not necessarily. Don't we basically do exactly that for the F00F bug
> workaround, for example?
>

We do, but only after matching on an exact address (is_f00f_bug()).
Note also that is_f00f_bug() isn't conditional on PF_USER.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/