Re: linux-next: build failure after merge of the akpm-current tree

From: Stephen Rothwell
Date: Sun Sep 01 2013 - 19:54:12 EST


Hi Linus,

On Fri, 30 Aug 2013 08:25:06 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Aug 30, 2013 at 1:12 AM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > I don't know if it is safe to read d_lockref.count without locking
>
> That's not the issue. Since commit 84d08fa888e7 ("helper for reading
> ->d_count") non-core VFS code shouldn't try to access d_count directly
> at all. So instead of "dentry->d_count" it should use
> "d_count(dentry)". Then the code doesn't need to know about lockrefs
> or anything like that at all.

Thanks for that. I will implement that temporary fix in linux-next today
unless Andrew has been busy over the weekend.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature