Re: [PATCH 0/8] partitions/efi: detect hybrid mbrs

[Karel Zak]

On Thu, Aug 15, 2013 at 06:37:19PM -0700, Davidlohr Bueso wrote:
> On Thu, 2013-08-15 at 12:29 -0700, Andrew Morton wrote:
> > On Thu, 15 Aug 2013 09:59:42 -0700 Davidlohr Bueso <davidlohr@xxxxxx> wrote:
> > 
> > > On Tue, 2013-08-06 at 14:16 -0700, Andrew Morton wrote:
> > > > On Mon,  5 Aug 2013 22:21:08 -0700 Davidlohr Bueso <davidlohr@xxxxxx> wrote:
> > > > 
> > > > > This patchset teaches the kernel about hybrid master boot records (MBRs), one of
> > > > > the most common issues with GUID partition tables, as a workaround to layout
> > > > > disk partitions to be compatible with both EFI and legacy MBR based systems.
> > > > > Except for adding more pmbr checks, to better comply with the UEFI/GPT specs, the
> > > > > functionality is left unchanged - we only inform (through debug) the user about
> > > > > the used MBR scheme. While it is true that these restrictions can be bypassed when
> > > > > forcing gpt, this is not the correct or default way of doing things, complicating
> > > > > users furthermore. More details are in the individual patches.
> > > > 
> > > > Patches look nice, although I'll cheerily admit to not having a clue
> > > > what they do.  What is a "hybrid MBR" anyway?
> > > > 
> > > > Someone's editor seems to replace tabs with spaces so the patches
> > > > generate quite a checkpatch storm.  Please use checkpatch.
> > > > 
> > > 
> > > Andrew, any chance of getting this in for 3.12?
> > 
> > gee, I didn't review the patches because I simply have no useful
> > knowledge in the area.  I can check the whitespace and code comments,
> > but that has the downside of creating the false impression that someone
> > actually reviewed the code :(
> > 
> > I'm struggling to think who might be better situated.  Matt Fleming or
> > Matt Domsch, maybe?
> > 
> 
> Cc'ing Matt Fleming.
> 
> Karel, I believe you took a look at these, any thoughts?

 Reviewed-by: Karel Zak <kzak@xxxxxxxxxx>

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/