Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment aboutupdating Documentation/CodingStyle
From: Shilong Wang
Date: Mon Sep 02 2013 - 20:26:27 EST
2013/9/3 Joe Perches <joe@xxxxxxxxxxx>:
> On Mon, 2013-09-02 at 21:50 +0100, David Howells wrote:
>> Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
>> > > There are many checkpatch rules (like semicolons) that
>> > > are not in CodingStyle.
>> > It's a rule of thumb, not a mandate. In *general*, checkpatch.pl should
>> > not be enforcing style rules that aren't documented in CodingStyle.
>> Except that it becomes a mandate when someone runs it automatically against
>> every one of your patches and then sends you an email for each patch it finds
>> a checkpatch niggle against...
Agree with this..
But using checkpatch.pl, i found there are *so many* patches that have
warnings or errors.
As far as i know, patches with checkpatch.pl's errors should be
avoided at least unless
there is a *bug* in checkpatch.pl!
> I think that any robot sending such checkpatch-only
> emails should be disabled.
> I know of 2 email robots.
> Fengguang Wu's very useful build robot
> sends out emails on build failures.
> I think that's great.
> Wang Shilong <wangshilong1991@xxxxxxxxx>
> sent me an automated checkpatch email I
> thought was not useful.
I am sorry if i give you any trouble, i have disabled it(in fact, it
only has run for a day!)
> Does anyone know of other checkpatch robots?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/