Re: [PATCH 1/2] input: allow SERIO=m even without EXPERT=y

From: Tom Gundersen
Date: Tue Sep 03 2013 - 09:41:42 EST


Sorry, this resend was accidental, please ignore. I only intended to
send patch 2/2.

On Tue, Sep 3, 2013 at 3:40 PM, Tom Gundersen <teg@xxxxxxx> wrote:
> There is plenty of consumer hardware (e.g., mac books) that does not use
> AT keyboards or PS/2 mice. It therefore makes sense for distro kernels
> to build the related drivers as modules to avoid loading them on hardware
> that does not need them. As such, these options should no longer be protected
> by EXPERT.
>
> Moreover, building these drivers as modules gets rid of the following ugly
> error during boot:
>
> [ 2.337745] i8042: PNP: No PS/2 controller found. Probing ports directly.
> [ 3.439537] i8042: No controller found
>
> Signed-off-by: Tom Gundersen <teg@xxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/input/keyboard/Kconfig | 4 ++--
> drivers/input/serio/Kconfig | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 269d4c3..2d31cec 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -2,7 +2,7 @@
> # Input core configuration
> #
> menuconfig INPUT_KEYBOARD
> - bool "Keyboards" if EXPERT || !X86
> + bool "Keyboards"
> default y
> help
> Say Y here, and a list of supported keyboards will be displayed.
> @@ -67,7 +67,7 @@ config KEYBOARD_ATARI
> module will be called atakbd.
>
> config KEYBOARD_ATKBD
> - tristate "AT keyboard" if EXPERT || !X86
> + tristate "AT keyboard"
> default y
> select SERIO
> select SERIO_LIBPS2
> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
> index 1e691a3..39c869d 100644
> --- a/drivers/input/serio/Kconfig
> +++ b/drivers/input/serio/Kconfig
> @@ -2,7 +2,7 @@
> # Input core configuration
> #
> config SERIO
> - tristate "Serial I/O support" if EXPERT || !X86
> + tristate "Serial I/O support"
> default y
> help
> Say Yes here if you have any input device that uses serial I/O to
> @@ -19,7 +19,7 @@ config SERIO
> if SERIO
>
> config SERIO_I8042
> - tristate "i8042 PC Keyboard controller" if EXPERT || !X86
> + tristate "i8042 PC Keyboard controller"
> default y
> depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \
> (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \
> @@ -170,7 +170,7 @@ config SERIO_MACEPS2
> module will be called maceps2.
>
> config SERIO_LIBPS2
> - tristate "PS/2 driver library" if EXPERT
> + tristate "PS/2 driver library"
> depends on SERIO_I8042 || SERIO_I8042=n
> help
> Say Y here if you are using a driver for device connected
> --
> 1.8.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/