Re: [PATCH] UBI: fix refill_wl_user_pool()

From: Richard Weinberger
Date: Wed Sep 04 2013 - 04:21:10 EST


Am 26.08.2013 12:08, schrieb Richard Weinberger:
> If no free PEBs are available refill_wl_user_pool() must not
> return with -ENOSPC immediately.
> It has to block till produce_free_peb() produced a free PEB.
>
> Reported-and-Tested-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> drivers/mtd/ubi/wl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index c95bfb1..02317c1 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -599,10 +599,6 @@ static void refill_wl_user_pool(struct ubi_device *ubi)
> return_unused_pool_pebs(ubi, pool);
>
> for (pool->size = 0; pool->size < pool->max_size; pool->size++) {
> - if (!ubi->free.rb_node ||
> - (ubi->free_count - ubi->beb_rsvd_pebs < 1))
> - break;
> -
> pool->pebs[pool->size] = __wl_get_peb(ubi);
> if (pool->pebs[pool->size] < 0)
> break;
>

Artem, please don't forget do apply this patch.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/