Re: [PATCH 2/3] Send comm and cmdline in SCM_PROCINFO

[Eric W. Biederman]

Jan Kaluza <jkaluza@xxxxxxxxxx> writes:

Nacked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Whatever the benefits of the other pieces of information sending the
process command line is absolutely wrong.  It is a just a random string
from user space and there is absolutely no benefit in sending it in a
kernel verified way.  The process can just as easily pass the
information in userspace directly.

Furthermore the implementation of scm_get_current_procinfo is so far
from idiomatic for reading information about the current process that I
think it is fair to call it broken.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/