Re: BUG: scheduling while atomic 3.10.7 in ZRAM Swap

From: Greg Kroah-Hartman
Date: Thu Sep 12 2013 - 12:43:06 EST


On Wed, Sep 11, 2013 at 06:08:08PM -0500, Mitch Harder wrote:
> On Tue, Aug 20, 2013 at 9:51 AM, Mitch Harder
> <mitch.harder@xxxxxxxxxxxxxxxx> wrote:
> > On Sun, Aug 18, 2013 at 11:44 PM, Minchan Kim <minchan@xxxxxxxxxx> wrote:
> >> Hello,
> >>
> >> On Mon, Aug 19, 2013 at 12:13:02PM +0800, Michael wang wrote:
> >>> Hi, Mitch
> >>>
> >>> On 08/17/2013 10:01 PM, Mitch Harder wrote:
> >>> > I'm encountering a BUG while using a ZRAM Swap device.
> >>> >
> >>> > The call trace seems to involve the changes recently added to 3.10.6
> >>> > by the patch:
> >>> > zram: use zram->lock to protect zram_free_page() in swap free notify path
> >>> >
> >>> > The hardware is a x86 single CPU AMD Athlon XP system with 1GB RAM.
> >>> >
> >>> > I'm implementing a 352MB ZRAM swap device, and also have 1GB swap
> >>> > space on the hard disk.
> >>>
> >>> IMHO, it was caused by that swap_entry_free() was invoked with page
> >>> spin-locked, thus zram_slot_free_notify() should not use rw-lock which
> >>> may goto sleep.
> >>>
> >>> CC folks related.
> >>
> >> Thanks for Ccing me, Michael,
> >>
> >> Mitch, It's known problem and it should be fixed by [1] in recent linux-next.
> >>
> >> [1] a0c516cbfc, zram: don't grab mutex in zram_slot_free_noity
> >>
> >> Thanks for the report!
> >>
> >
> > Thanks.
> >
> > If I apply the zram patches from linux-next, the problem seems to be resolved.
>
> Is it planned to send the patch: "zram: don't grab mutex in
> zram_slot_free_noity" to stable?
>
> I noticed that 3.10.11 still doesn't have this patch.

That's because it isn't in a released kernel from Linus yet. Wait for
3.12-rc1 to come out, then I will queue it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/