Re: [PATCH 012/228] cpufreq: sparc: callcpufreq_frequency_table_get_attr()

[David Miller]

From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Date: Fri, 13 Sep 2013 18:29:18 +0530

> This exposes frequency table of driver to cpufreq core and is required for core
> to guess what the index for a target frequency is, when it calls
> cpufreq_frequency_table_target(). And so this driver needs to expose it.
> 
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: sparclinux@xxxxxxxxxxxxxxx
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Wait a second, later in this series you add the put_attr() call claiming
it's a fix.

But you're the one adding the "bug" here.

So if you are going to add a get_attr() call you should be adding the
necessary put_attr() call in the same patch.  Otherwise this patch
introduces a bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/