Re: [PATCH 1/4 v2] mfd: add STw481x driver

From: Mark Brown
Date: Mon Sep 16 2013 - 06:40:19 EST


On Mon, Sep 16, 2013 at 10:19:56AM +0100, Lee Jones wrote:

> Can't you just NULL .id_table?

> Here's the code which would use it:
> > /* match on an id table if there is one */
> > if (driver->id_table)
> > return i2c_match_id(driver->id_table, client) != NULL;

> Matching for "dummy" will just waste cycles.

i2c_device_probe() will return -ENODEV if id_table is NULL before we get
to actually matching. We could remove that check though...

Attachment: signature.asc
Description: Digital signature