Re: [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk withnetdev_err

[Joe Perches]

On Mon, 2013-09-16 at 15:43 +0200, Iker Pedrosa wrote:
> The previously used printk lacked the warning level, now we've got a more accurate way to know the error.
[]
> diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
[]
> @@ -32,7 +32,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
>  	struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
>  	struct wb35_mds *pMds = &adapter->Mds;
>  
> -	printk("wb35: tx complete\n");
> +	netdev_err(pUrb->dev, "wb35: tx complete\n");

This one should either be removed or changed to netdev_dbg
with the "wb35: " prefix removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/