Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()

From: Tony Lindgren
Date: Tue Sep 17 2013 - 19:44:37 EST


* Suman Anna <s-anna@xxxxxx> [130823 09:50]:
> + OMAP mailing list
>
> Tony,
> Can you pick up this minor cleanup patch?
>
> regards
> Suman
>
> On 08/21/2013 09:10 PM, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
>
> Acked-by: Suman Anna <s-anna@xxxxxx>

OK applying into omap-for-v3.12/fixes thanks.

Regards,

Tony

> > ---
> > drivers/mailbox/mailbox-omap2.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c
> > index eba380d..42d2b89 100644
> > --- a/drivers/mailbox/mailbox-omap2.c
> > +++ b/drivers/mailbox/mailbox-omap2.c
> > @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev)
> > kfree(privblk);
> > kfree(mboxblk);
> > kfree(list);
> > - platform_set_drvdata(pdev, NULL);
> >
> > return 0;
> > }
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/