Re: [PATCH] net: tsi108: Prevent compiler warning

From: David Miller
Date: Wed Sep 18 2013 - 12:39:00 EST


From: Thierry Reding <thierry.reding@xxxxxxxxx>
Date: Wed, 18 Sep 2013 14:49:55 +0200

> The dump_eth_one() function is only used if DEBUG is enabled, so protect
> it by a corresponding #ifdef DEBUG block.
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

I would prefer that this function and the one call site is simply
removed instead.

This kind of thing can be provided via ethtool register dumps
and therefore without all of the ugliness this ad-hoc stuff
presents.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/