Re: [PATCHv4 02/16] drivers: thermal: introduce device tree parser

[Eduardo Valentin]

On 18-09-2013 17:00, Joe Perches wrote:
> On Wed, 2013-09-18 at 16:52 -0400, Eduardo Valentin wrote:
>> On 18-09-2013 16:44, Joe Perches wrote:
>>> On Wed, 2013-09-18 at 16:31 -0400, Eduardo Valentin wrote:
>>>
>>>> +/**
>>>> + * of_parse_thermal_zones - parse device tree thermal data
>>>> + *
>>>> + * Initialization function that can be called by machine initialization
>>>> + * code to parse thermal data and populate the thermal framework
>>>> + * with hardware thermal zones info. This function only parses thermal zones.
>>>> + * Cooling devices and sensor devices nodes are supposed to be parsed
>>>> + * by their respective drivers.
>>>> + *
>>>> + * Return: 0 on success, proper error code otherwise
>>>> + *
>>>> + */
>>>> +int __init of_parse_thermal_zones(void)
>>>> +{
>>>> +	struct device_node *np, *child;
>>>> +	struct __thermal_zone *tz;
>>>> +	struct thermal_zone_device_ops *ops;
>>>> +
>>>> +	np = of_find_node_by_name(NULL, "thermal-zones");
>>>> +	if (!np) {
>>>> +		pr_err("unable to find thermal zones\n");
>>>> +		return 0;
>>>
>>> return 0? This is success?
>>
>> This case is success because there should be systems without thermal DT
>> entries.
> 
> Then the pr_err should be pr_notice/info or not there at all.

Yeah, done in v5.

> 
> []
> 
>>>> +		/* No hwmon because there might be hwmon drivers registering */
>>>> +		tzp->no_hwmon = true;
>>>> +
>>>> +		zone = thermal_zone_device_register(child->name, tz->ntrips,
>>>> +						    0, tz,
>>>> +						    ops, tzp,
>>>> +						    tz->passive_delay,
>>>> +						    tz->polling_delay);
>>>> +		if (IS_ERR(zone))
>>>> +			pr_err("Failed to build %s zone %ld\n", child->name,
>>>> +			       PTR_ERR(zone));
> 
> Should there should be a return -ERR here?
> 

well, no, there might be other correct thermal zones in DT that needs
parsing.

>> hmmm.. I am sending after reworking the return code of this function.
> 
> thanks.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

Attachment: signature.asc
Description: OpenPGP digital signature