Re: [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPII/O function

From: Lee Jones
Date: Thu Sep 19 2013 - 05:13:34 EST


On Wed, 18 Sep 2013, Mark Brown wrote:

> From: Mark Brown <broonie@xxxxxxxxxx>
>
> Move the workaround for double sending AUDIO_CODEC and AUDIO_DAC writes
> into the SPI core, aiding refactoring to eliminate the ASoC custom I/O
> functions and avoiding the extra writes for I2C.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> drivers/mfd/mc13xxx-spi.c | 5 +++++
> include/linux/mfd/mc13xxx.h | 7 +++++++
> sound/soc/codecs/mc13783.c | 4 ----
> 3 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
> index 77189da..363c359 100644
> --- a/drivers/mfd/mc13xxx-spi.c
> +++ b/drivers/mfd/mc13xxx-spi.c
> @@ -94,10 +94,15 @@ static int mc13xxx_spi_write(void *context, const void *data, size_t count)
> {
> struct device *dev = context;
> struct spi_device *spi = to_spi_device(dev);
> + char *reg = data;

I think this requires a cast.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/