Re: [PATCH 46/50] sched: numa: Prevent parallel updates to groupstats during placement

From: Mel Gorman
Date: Fri Sep 20 2013 - 09:31:39 EST


On Fri, Sep 20, 2013 at 01:31:51PM +0100, Mel Gorman wrote:
> @@ -1402,14 +1394,15 @@ unlock:
> if (!join)
> return;
>
> + double_lock(&my_grp->lock, &grp->lock);
> +
> for (i = 0; i < 2*nr_node_ids; i++) {
> - atomic_long_sub(p->numa_faults[i], &my_grp->faults[i]);
> - atomic_long_add(p->numa_faults[i], &grp->faults[i]);
> + my_grp->faults[i] -= p->numa_faults[i];
> + grp->faults[i] -= p->numa_faults[i];
> + WARN_ON_ONCE(grp->faults[i] < 0);
> }

That stupidity got fixed

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/