Re: [PATCH -next] dma: mmp_pdma: use list_move instead oflist_del/list_add

From: Vinod Koul
Date: Mon Sep 23 2013 - 06:53:33 EST


On Mon, Sep 23, 2013 at 02:07:20PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Using list_move() instead of list_del() + list_add().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
Applied, thanks

~Vinod
> ---
> drivers/dma/mmp_pdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
> index ff8d7827..558994f 100644
> --- a/drivers/dma/mmp_pdma.c
> +++ b/drivers/dma/mmp_pdma.c
> @@ -798,8 +798,7 @@ static void dma_do_tasklet(unsigned long data)
> * move the descriptors to a temporary list so we can drop
> * the lock during the entire cleanup operation
> */
> - list_del(&desc->node);
> - list_add(&desc->node, &chain_cleanup);
> + list_move(&desc->node, &chain_cleanup);
>
> /*
> * Look for the first list entry which has the ENDIRQEN flag
>

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/