Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

From: Roger Quadros
Date: Mon Sep 23 2013 - 09:59:48 EST


On 09/23/2013 03:59 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 23-09-2013 11:37, Roger Quadros wrote:
>
>>>> Not sure why you asked -- I'm not using this driver, neither I'm
>
>>> Well, you have better grip of what's going on in the embedded world
>>> than me. I'm mostly curious whether adding dependency on PHY is okay.
>
>> There is no hard dependency on presence of PHY. The driver will continue
>> as usual if devm_phy_get() fails.
>> I hope selecting GENERIC_PHY in Kconfig is not an issue.
>
> Selecting in the AHCI_PLATFORM section? It seems I have overlooked it. No, I don't think it's a good idea. The generic PHY functions seem to be stubbed when GENERIC_PHY=n.
>
OK I will remove the select then.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/