Re: False positive in checkpatch

From: Andy Whitcroft
Date: Tue Sep 24 2013 - 11:13:55 EST


On Tue, Sep 24, 2013 at 07:03:05AM -0700, Paul E. McKenney wrote:
> On Mon, Sep 23, 2013 at 09:21:07PM -0700, Joe Perches wrote:
> > On Mon, 2013-09-23 at 15:59 -0700, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > The checkpatch.pl script complains as follows:
> > >
> > > ERROR: need consistent spacing around '*' (ctx:WxB)
> > > #57: FILE: include/linux/rcupdate.h:564:
> > > + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \
> > >
> > > Of course, the two uses of '*' are doing different things, so it should
> > > be OK for the spacing to be different.
> > >
> > > Could you please fix this?
> > >
> > > Thanx, Paul
> > >
> >
> > Hi Paul.
> >
> > Try this patch: https://lkml.org/lkml/2013/9/2/428
> >
> > Andy? Can you verify this suggested patch please?
>
> That does it, thank you! And it does look like this patch was directed
> precisely at this patch. ;-)
>
> Thanx, Paul
>

How about this one, it is a bit of a hack but does at least correctly
correct the formal characterisation of the operator to unary.

Working on getting this tested a bit better before sending it out
formally.

-apw