Re: checkpatch guide for newbies
From: Dan Carpenter
Date: Tue Sep 24 2013 - 16:00:24 EST
On Tue, Sep 24, 2013 at 09:29:49PM +0200, Peter Senna Tschudin wrote:
> I was about to disagree because I've never seen variables named a, b
> or c, but I found that there are at least 2238 variables named a, b or
> c in linux-next. This is not good.
>
In XGIfb_mode_rate_to_ddata() we have:
int B, C, D, F, temp, j;
The A and E variables were removed when the code was refactored. ;P
Places like this are fairly rare in the kernel outside of the staging/
directory.
There are lots of times where a single letter variable name is very
natural.
char c;
C is terse. This is explained in Documentation/CodingStyle.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/