Re: [PATCH RESEND] clocksource: of: respect device tree node status

From: Sebastian Hesselbarth
Date: Wed Sep 25 2013 - 11:34:45 EST


On 09/25/2013 05:29 PM, Daniel Lezcano wrote:
On 09/19/2013 12:47 PM, Sebastian Hesselbarth wrote:
Clocksource devices provided by DT can be disabled (status != "okay").
Instead of registering clocksource drivers for disabled nodes, respect
the device's status by skiping disabled nodes.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>

Shall it be applied as a 3.12 fix ?

Daniel,

difficult to say. Although I am not aware of any mainline mach
depends on it, I consider this a fix. So, if there are no objections
please apply for 3.12.

Sebastian

---
Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
---
drivers/clocksource/clksrc-of.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/clocksource/clksrc-of.c
b/drivers/clocksource/clksrc-of.c
index 37f5325..b9ddd9e 100644
--- a/drivers/clocksource/clksrc-of.c
+++ b/drivers/clocksource/clksrc-of.c
@@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
clocksource_of_init_fn init_func;
for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
+ if (!of_device_is_available(np))
+ continue;
+
init_func = match->data;
init_func(np);
}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/