Re: [PATCH] staging: dgrp: Convert to use device_create_with_groups

[Greg Kroah-Hartman]

On Sat, Aug 31, 2013 at 03:56:06PM -0700, Guenter Roeck wrote:
> Use device_create_with_groups to create sysfs attributes together with device.
> Also create class attribute together with class registration.
> This simplifies the code and ensures that attribute files exist when udev
> events are generated.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> I suspect that the 'register_with_sysfs' attribute exists to work around
> the problem solved with this patch. It doesn't make much sense otherwise.
> Can it be removed ?

All of these sysfs files can be removed, they shouldn't be there, as it
looks like they are used for odd configuration things.

And a single tty driver shouldn't be a "class" at all.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/