Re: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller

From: Maxime COQUELIN
Date: Thu Sep 26 2013 - 05:31:23 EST



On 09/24/2013 05:59 PM, Wolfram Sang wrote:
>> "glitch" is is used to tune the I2C timing requirements, and has a
>> nanosecond granularity.
>> These values are added to default timing values.
>> I'm not 100% sure, but it looks like the "samsung,i2c-sda-delay" in the
>> i2c-s3c2410 driver.
> For that, we have the generic "i2c-sda-hold-time-ns" property. The s3c
> driver hasn't been converted to use it, sadly.
>
Ok, thank you for pointing this out.
After some checks, this property doesn't match with what is done in this
driver.

In the v2 series I am sending, I removed the I2C timing tuning as it
works on all
the boards I have tested with.
I will only keep the anti-glitch filtering, using private properties as
I didn't find any generic
ones that could fit.

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/